fix(collapse): restore previous transition logic #4388
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR restores the previous collapse transition logic that was changed with #4370.
Without this PR, the show and hide phases are inconsistent: the hide phase is from the full size of the container to
0px
, and the show phase is from0px
to thescrollWidth
/scrollHeight
of the container and then there is a sudden change when the classes are changed at the end of the transition.Using
scrollWidth
/scrollHeight
does not feel right for me. We should use whatever size the container will have when changing the classes at the end of the transition, which is whatmeasureCollapsingElementDimensionPx
measures correctly. I have addedstyle="max-width:300px;"
on the container in the demo so that the animation matches the visible content.Before submitting a pull request, please make sure you have at least performed the following: