fix(accordion): fixes inconsistent closeOthers behavior
#4490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously `closeOthers` consistency was enforced only at the accordion level with `accordion.toggle(itemId)`, `accordion.expand(itemId)`, etc. This change ensures that: - `item.toggle()`, `item.expand()` and `item.collapsed = false` respect that only one item stays open - only one item can be opened initially even with several with `[collapse]="false"`
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #4490 +/- ##
==========================================
- Coverage 88.88% 88.87% -0.01%
==========================================
Files 115 115
Lines 4101 4099 -2
Branches 867 864 -3
==========================================
- Hits 3645 3643 -2
Misses 416 416
Partials 40 40
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
closeOthersconsistency was enforced only at the accordion level withaccordion.toggle(itemId),accordion.expand(itemId), etc.This change ensures that:
item.toggle(),item.expand()anditem.collapsed = falserespect that only one item stays open[collapse]="false"cc @ValentinNelu