fix(dropdown): add show class to dropdown toggle when dropdown is open
#4532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `show` class on dropdown toggle will keep the button element in active state, inditicating that dropdown is open. This small change was made between Bootstrap v4 and v5. Fixes ng-bootstrap#4531
|
I hesitate to remove |
maxokorokov
force-pushed
the
master
branch
16 times, most recently
from
0e2d9ff
to
df17d50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
showclass on dropdown toggle will keep the button element in active state, inditicating that dropdown is open. This small change was made between Bootstrap v4 and v5.Fixes #4531