Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: accessibility fixes + e2e axe #4588

Merged
merged 1 commit into from Oct 26, 2023
Merged

feat: accessibility fixes + e2e axe #4588

merged 1 commit into from Oct 26, 2023

Conversation

ValentinNelu
Copy link
Contributor

Before submitting a pull request, please make sure you have at least performed the following:

  • read and followed the CONTRIBUTING.md and DEVELOPER.md guide.
  • built and tested the changes locally.
  • added/updated any applicable tests.
  • added/updated any applicable API documentation.
  • added/updated any applicable demos.

@maxokorokov maxokorokov added this to the 16.0.0 milestone Oct 25, 2023
maxokorokov
maxokorokov requested changes Oct 25, 2023
View reviewed changes
Copy link
Member

@maxokorokov maxokorokov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment about ids

src/carousel/carousel.ts Outdated Show resolved Hide resolved
@ValentinNelu ValentinNelu force-pushed the feat/carousel-accessibility branch 3 times, most recently from 3f4dddc to 1b4d81e Compare October 26, 2023 09:19
maxokorokov
maxokorokov approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@maxokorokov maxokorokov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@maxokorokov maxokorokov merged commit b573a2b into ng-bootstrap:master Oct 26, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxokorokov maxokorokov maxokorokov approved these changes

Assignees
No one assigned
Labels
type: accessibility type: demo site type: demo
Projects
None yet
Milestone
16.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ValentinNelu @maxokorokov