Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(timepicker): format input values on blur #517

Closed
wants to merge 1 commit into from
Closed

fix(timepicker): format input values on blur #517

wants to merge 1 commit into from

Conversation

pkozlowski-opensource
Copy link
Member

Fixes #511

@wesleycho
Copy link
Member

So this doesn't really format on blur as far as I can tell, but on the change output. Is that sufficient? As far as I can tell, this theoretically shouldn't change anything.

Also, should this use the input output if we go the output route? Or do we need to use (blur)?

@pkozlowski-opensource
Copy link
Member Author

So this doesn't really format on blur as far as I can tell, but on the change output

That's the intention. I can change the commit message.

Is that sufficient? As far as I can tell, this theoretically shouldn't change anything.

Actually it changes everything :-) So far we were using ngModel which updates on input (each key stroke). This PR changes to the reaction to the change event (user "done" editing - in case of input fields it is equivalent to blur).

Also, should this use the input output if we go the output route?

Not sure what you mean here...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants