You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
But if we move to NgModules this directive gets activated on all labels with the btn class (quite common scenario). And it can mess up scenarios like this:
<labelclass="btn btn-primary" [class.active]="model.left"><inputtype="checkbox" [(ngModel)]="model.left"> Left (pre-checked)
</label>
In this scenario [class.active]="model.left" will be overridden by the NgbRadioLabel directive and will never take effect. We can't remove active label when the directive is not used / manipulated from outside.
The text was updated successfully, but these errors were encountered:
The
NgbRadioLabel
as implemented today prevents checkbox demo from working correctly. It is implementation is very simple:But if we move to NgModules this directive gets activated on all labels with the
btn
class (quite common scenario). And it can mess up scenarios like this:In this scenario
[class.active]="model.left"
will be overridden by the NgbRadioLabel directive and will never take effect. We can't removeactive
label when the directive is not used / manipulated from outside.The text was updated successfully, but these errors were encountered: