feat(datepicker): add config service to provide default values #677
Conversation
|
@jnizet needs rebasing |
| config.firstDayOfWeek = 2; | ||
| config.markDisabled = (date) => false; | ||
| config.minDate = {year: 2000, month: 0, day: 1}; | ||
| config.maxDate = {year: 2030, month: 1, day: 31}; |
There was a problem hiding this comment.
I don't think 31FEB is a valid day. :-)
There was a problem hiding this comment.
Do we want to hard code this as a value or can we calculate it as added time from the minDate? The reason I ask is because in other calendar systems, 01JAN is not the first of the year.
This may mean that we need to have a base config object and have different calendars have different extensions of the config - which I'm ok with. @pkozlowski-opensource @jnizet, thoughts?
If a base config is the way we decide to go, then we'd need a Gregorian config subclass.
There was a problem hiding this comment.
If I read the code correctly:
By default, if left undefined, the min date is computed by using the 1st of January of ten years before the start date (or now if there is no start date).
By default, if left undefined, the max date is computed by using the 31 of December of ten years after the start date (or now if there is no start date).
@maxokorokov can you confirm?
But this is done by the Calendar abstraction, which by default is Gregorian, but can be changed to another implementation. So I think we're fine here.
Note that the above function is just used in unit tests to check that custom config values are honored by the component. I didn't change anything to the min/max date selection logic.
|
@jnizet I don't see any default values for the config. Was this intentional? |
|
The config service uses the same default values as the original datepicker component. Except for the first day of week and for the boolean flags, the default value is |
jnizet
force-pushed
the
feat/datepicker-config
branch
from
1aa645c
to
d100790
Compare
|
Hey @jnizet, sorry for a late reply. On vacations here :) |
refs #518