Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dropdown: open/close events should only be fired if necessary #694

Closed
jnizet opened this issue Sep 6, 2016 · 1 comment
Closed

dropdown: open/close events should only be fired if necessary #694

jnizet opened this issue Sep 6, 2016 · 1 comment

Comments

@jnizet
Copy link
Member

jnizet commented Sep 6, 2016

Currently, close events are emitted everytime the dropdown is closed, even if it's in fact already closed. In particular, since the dropdown adds a click listener to the document to close itself when a click happens outside the dropdown, a close event is emitted by the dropdown every time we click anywhere on the document.

The same goes for open events: an event is emitted when the dropdown is opened, even if it's already open.

This doesn't look right to me.

@pkozlowski-opensource
Copy link
Member

@jnizet good catch, this is definitively a bug. Opened the #695 for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants