Modal: string argument to the open method is confusing

[pkozlowski-opensource]

See http://stackoverflow.com/q/39464345/1418796

Really, the string argument is only good for unit-testing but not for any real-life applications. We should remove it altogether or at least clarify in the docs.

On top of this we need to support components as arguments to the open method, see #680

[felixfbecker]

How about something like

ngbModal.open(MyModalComponent).then(value => ...

where the component is passed the modal instance as an @input?

to avoid having to specify @Input it could also be possible to subclass a ModalComponent:

import {ModalComponent} from '@ng-bootstrap/ng-bootstrap'

@Component({})
class MyModalComponent extends ModalComponent {
  ngOnInit() {
    this.modal.close(value) // or
    this.modal.dismiss(value)
  }
}

where ModalComponent is something like:

abstract class MyModalComponent {
  @Input()
  public modal: ModalInstance
}

[felixfbecker]

Actually it would be very ng1-ish to pass the modal instance as an input. Better would be to have two outputs, close and dismiss.

[felixfbecker]

This here does something similar: http://plnkr.co/edit/ZAZqZu?p=preview

[SanderElias]

My vote would go on removing the string argument completely, as it's just utterly confusing.
Adding the component support to the open method makes a lot of sense. This will take out quite some boileplate code that is now needed to support the usecase of #680

[pkozlowski-opensource]

For anyone interested in this issue, here is the design doc for introducing components as arguments to the open method: https://docs.google.com/document/d/1puwnSknaW3bLg_Ww2ewuILneCom1wbMTArvfFq0YFV8/edit?usp=sharing