fix(dropdown): change to contains #810
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change to check if event target is contained in toggle to catch all child element clicks
maxokorokov
approved these changes
Sep 28, 2016
| @@ -190,6 +190,30 @@ describe('ngb-dropdown-toggle', () => { | |||
| expect(buttonEl.getAttribute('aria-expanded')).toBe('false'); | |||
| }); | |||
|
|
|||
| it('should toggle dropdown on click of child of toggle', () => { | |||
There was a problem hiding this comment.
phrasing confused me a little when I first read it, but can't come up with a better one :)
|
LGTM. Make sure that you add reference to the issue being closed in the commit message while merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #803.