feat(rating): allow decimal numbers as rating values #817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxokorokov
force-pushed
the
rating_decimal
branch
from
b415d47
to
00f7019
Compare
| /** | ||
| * internal | ||
| */ | ||
| getFillValue(index: number): number { |
There was a problem hiding this comment.
Remove the JS doc comment. The way it is written right now it would show up in the API doc.
|
LGTM apart from the comment I've left. |
wesleycho
reviewed
Sep 30, 2016
| <span *ngIf="fill === 100" class="star full">♥</span> | ||
| <span *ngIf="fill === 0" class="star">♥</span> | ||
| <span *ngIf="fill < 100 && fill > 0" class="star"> | ||
| <span class="half" style.width="{{fill + '%'}}">♥</span>♥ |
There was a problem hiding this comment.
style.width works like this so that one wouldn't need to use a binding?
There was a problem hiding this comment.
One could also write: [style.width.%]="fill" if I'm not mistaken.
There was a problem hiding this comment.
Kinda works both ways [style.width]="" and style.width='{{}}', but will try the one @pkozlowski-opensource is suggesting!
There was a problem hiding this comment.
[style.width.%] works fine, thanks
maxokorokov
force-pushed
the
rating_decimal
branch
from
00f7019
to
e14df0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #801
Allows for fine-grained rating values like
3.72.Properly handles decimal numbers and template
fillvalue when updated via[rate]binding.Plus a small readonly demo.