fix(buttons): use disabled state from a control #828
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -312,11 +316,35 @@ describe('ngbRadioGroup', () => { | |||
| expect(getGroupElement(fixture.nativeElement)).toHaveCssClass('ng-valid'); | |||
| expect(getGroupElement(fixture.nativeElement)).not.toHaveCssClass('ng-invalid'); | |||
| }); | |||
|
|
|||
| it('should disable label and input when it is disabled using reactive forms', () => { | |||
There was a problem hiding this comment.
Could you also add a test for template-driven forms? I know that the current implementation should work, but better to be safe than sorry...
There was a problem hiding this comment.
Amended the test for template-driven forms
|
LGTM but I would be even more happy if we could have a test for template-driven forms :-) |
maxokorokov
force-pushed
the
radio_disabled_state
branch
from
36e908f
to
4d10dd2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
.disabledclass on the label anddisabledattribute on the input of radios in case form control becomes disabled.Fixes #805