Stack Modals in Opening Order #901
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Alright, I retract my earlier comment - there's still a lot to be done for proper stack modal support. That said, I can't see how this isn't an improvement, as it allows for multi modals in simple cases. |
|
Agreed, much more would have to be done to fully support stacked modals. At the same time I don't see harm in merging this one so going to land it, thnx. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small change to attach modal elements in the order that they were opened (rather than always prepending everything)
Actually, this change alone seems to allow most of what's necessary for #643 - at least in terms of presenting multiple modals. There's still work to do for visually making it better (hiding inactive modals, backdrop management, etc)