Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't focus accordion panel title #942

Closed
cmckni3 opened this issue Oct 21, 2016 · 3 comments
Closed

Don't focus accordion panel title #942

cmckni3 opened this issue Oct 21, 2016 · 3 comments
Labels
component: accordion needs: investigation
Milestone
alpha.10

Comments

@cmckni3
Copy link
Contributor

cmckni3 commented Oct 21, 2016

Should the tabindex be set to -1 here?

Version of Angular, ng-bootstrap, and Bootstrap:

Angular: 2.1.0

ng-bootstrap: 1.0.0-alpha.9

Bootstrap: 4.0.0-alpha.5
@pkozlowski-opensource
Copy link
Member

I think that we shouldn't have tabindex there at all and allow natural (order-defined) tab order. Honestly I've got no idea how tabindex="0" made it into the template (the only thing to test is if we get right tab order with an empty href)

@cmckni3 cmckni3 mentioned this issue Oct 21, 2016
Closed
@cmckni3
Copy link
Contributor Author

cmckni3 commented Oct 21, 2016

Removing the tabindex appears to maintain the correct tab order. It also fixed my issue with the input being focused.

See PR #943

@pkozlowski-opensource
Copy link
Member

See PR #943

Thnx! I will review / merge as soon as internet & Travis infrastructure is back :-)

@pkozlowski-opensource pkozlowski-opensource added this to the alpha.10 milestone Oct 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: accordion needs: investigation
Projects
None yet
Milestone
alpha.10
Development

No branches or pull requests
2 participants
@cmckni3 @pkozlowski-opensource