feat(typeahead): allow selection of null item #958
Conversation
| /** | ||
| * The input target | ||
| */ | ||
| target: any; |
There was a problem hiding this comment.
Wasn't sure if you were trying to avoid this, but it would be nice to have access to the input for the select event to be able to call blur, etc.
| @@ -187,6 +192,12 @@ export class NgbTypeahead implements ControlValueAccessor, | |||
|
|
|||
| handleKeyDown(event: KeyboardEvent) { | |||
| if (!this._windowRef) { | |||
| if (event.which === Key.Enter) { | |||
There was a problem hiding this comment.
I did not want to do it for tab also, since I would still want tab to move focus to the next focusable item.
I'm not sure I would ever really want tab to select an item from the autocomplete. Maybe this is something we can make configurable in the future?
deeg
force-pushed
the
typeahead-select-empty
branch
from
c39df65
to
26cdb1f
Compare
|
@pkozlowski-opensource, am I missing anything for this to get started being reviewed? Mind if I get a needs review tag so someone can take a look when they have time? |
|
@deeg sorry for the delay. I'm batching several items for typeahead and will work on this early next week. |
|
@deeg would you mind having a look at #877 (comment) ? |
Closes ng-bootstrap#958 Closes ng-bootstrap#877 Closes ng-bootstrap#980 Closes ng-bootstrap#1032
Allows selection of empty item when focusFirst = false and focus is not on any options from the typeahead results.
Closes #877