fix(modal): make it easier to use components from lazy-loaded modules #974
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Soooooo, this is the first time when I'm kind of puzzled on how to write a test for this.
The issue here is that each lazy loaded module gets its own instance of
ComponentFactoryResolver
so to test this situation we would have to simulate lazy-loaded modules and I'm not sure sure how to do this under a test (not that I've researched this extensively...)Fixes #947