Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot use lazy loaded services in components as content for modals #982

Closed
TVrijdag opened this issue Oct 28, 2016 · 1 comment
Closed

Comments

@TVrijdag
Copy link

Bug description:

In this version an issue has been fixed to open components as content for modals in lazy loaded modules. Unfortunately I have just encountered an issue related to using lazy loaded services within such modal component. Luckily there is no issue with services provided by the main module.

The plunker below throws the error: No provider for LazyService!

Link to minimally-working plunker that reproduces the issue:

http://plnkr.co/edit/G0PBVwHAN7zgOHscCAax?p=preview

Version of Angular, ng-bootstrap, and Bootstrap:

Angular: 2.1.0

ng-bootstrap: 1.0.0-alpha.10

Bootstrap: 4.0.0-alpha.5

@pkozlowski-opensource
Copy link
Member

@TVrijdag I'm sorry for missing this one, should have thought that we need pass down the Injector as well :-/. This is a very easy fix, will send a patch & cut a new release over the weekend.

Thnx for bearing with us....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants