Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support node 18, but this could be a parameter #355

Closed
kekel87 opened this issue Mar 25, 2023 · 2 comments
Closed

Support node 18, but this could be a parameter #355

kekel87 opened this issue Mar 25, 2023 · 2 comments

Comments

@kekel87
Copy link

kekel87 commented Mar 25, 2023

Hello, it's me again 馃檭

Thanks again for the responsiveness on node 16 馃檹

There are some projects I'd like to migrate to node 18, do you think it's possible to support this version?

It would be even better if it could be parametrizable. 馃

Thanks

@samuelfernandez
Copy link
Member

Hey @kekel87! Thanks for swinging back again, you are like dependabot 馃槣

I'll update this on Monday if it is ok with you. Initially I thought that parametrizing the node version was not possible, since it uses: https://docs.github.com/en/actions/creating-actions/metadata-syntax-for-github-actions#runs-for-javascript-actions

But I'll give a try with optional steps and see how it goes.

@samuelfernandez
Copy link
Member

samuelfernandez commented Mar 27, 2023

It seems that it is still not possible to use node18 in custom JS actions, check this thread

image

As explained in the thread, it should not affect your code as long as you configure the setup-node action before npm-setup, there you can specify the version you want your code to run.

Sorry that I can't update yet. Closing by now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants