Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular compatibility #146

Closed
KQuiskamp opened this issue Jun 12, 2023 · 3 comments
Closed

Angular compatibility #146

KQuiskamp opened this issue Jun 12, 2023 · 3 comments
Assignees

Comments

@KQuiskamp
Copy link
Collaborator

I have run some test in older projects with angular 15.x.

The newest @ng-maps/core@5.0.1 and @ng-maps/google@5.0.2 package do not work here. In angular project 16.x all packages works fine.

The error look like a typescript error after building with ng-packagr. 16.0.0 the typescript 4.8 used in angular 15.x is deprecated.

I guess we must use 15.2.2 for compiling angular 15.x versions.

Maybe we should use the major version for the angular version in our packages and the minor for adding new features.

So our versions always equals the angular versions for better understanding.

image

@DaSchTour
Copy link
Contributor

DaSchTour commented Jun 12, 2023

If there is the need for a version that is compatible with angular 15 I would see if we can port changes to the older 4 version.

As there is no big team for maintaining this I not like to increase complexity in maintaining multiple version.

@KQuiskamp
Copy link
Collaborator Author

As the @angular/core statistics shows, angular 15.x and angular 14.x are currently most used by people.
I guess in a few weeks they will update the applications to 16.x, so maintaining multiple versions are not necessary.

Because the packages do not work in angular 15.x and 14.x, I would suggest remove the peer Dependencies for @angular/core 15.x and 14.x to avoid confusion.

@DaSchTour DaSchTour self-assigned this Jun 13, 2023
@rushvora
Copy link

I ended up adding skipLibCheck: true to fix this issue for an Angular 15 based application.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants