Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs/Readme have incorrect import instructions #62

Closed
warmans opened this issue Feb 11, 2022 · 3 comments
Closed

Docs/Readme have incorrect import instructions #62

warmans opened this issue Feb 11, 2022 · 3 comments
Assignees

Comments

@warmans
Copy link

warmans commented Feb 11, 2022

The docs suggest importing the core module with a forRoot() call to pass the apiKey. But the sample application passes the key through a provider (and indeed forRoot is not applicable to the exported core module). Additionally it's not clear that to use google maps the google module must also be imported.

@DaSchTour DaSchTour self-assigned this Feb 11, 2022
@nerd-cs
Copy link

nerd-cs commented May 26, 2022

@DaSchTour
From the documentation, it suggest to add apiKey in forRoot() NgMapsCoreModule.forRoot()
but I can't use forRoot() in app.module.ts

@warmans
Copy link
Author

warmans commented May 26, 2022

The sample application shows the correct way to import the module:

https://github.com/ng-maps/ng-maps/blob/master/projects/sample/src/app/app.module.ts#L25

@DaSchTour
Copy link
Contributor

I updated the docs. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants