Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Maps Types moved to different NPM package (conflict between old and new) #72

Closed
geferon opened this issue Sep 7, 2022 · 2 comments
Assignees

Comments

@geferon
Copy link

geferon commented Sep 7, 2022

The Google maps types have moved to @types/google.maps, @types/googlemaps being deprecated.
The package included by @ng-maps/marker-clusterer includes @types/markerclustererplus (as seen in

"@types/markerclustererplus": "^2.1.0"
) which has @types/google-maps as a dependency, which at the same time has @types/google.maps as a dependency itself.

This makes it so whenever both packages are installed, and you try to compile, @types/googlemaps and @types/google.maps conflict with each other.
The solution would be to update the typings in the @ng-maps/marker-clusterer library from @google/markerclusterer to @googlemaps/markerclusterer

"@google/markerclusterer": "^2.0.0",

and swap @types/markerclustererplus for @types/google.maps, as in the new versions the markerclusterer is included in it.

@DaSchTour DaSchTour self-assigned this Sep 10, 2022
@ivan-janssens-de-varebeke-lemon

I encountered the same issue. Has there been a fix for this or a workaround?

@DaSchTour
Copy link
Contributor

New version 4 is released with updates for angular and google maps typings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants