Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Externals #192

Closed
KoLogicDev opened this issue Oct 18, 2017 · 2 comments
Closed

Externals #192

KoLogicDev opened this issue Oct 18, 2017 · 2 comments

Comments

@KoLogicDev
Copy link

KoLogicDev commented Oct 18, 2017

Type of Issue

[x] Bug Report
[] Feature Request

Description

Hi guys, thanks for awesome tool! I'm trying to build my own library on top of devextreme-angular. In its turn it depends on devextreme, jQuery and JSzip. After simply addition these packages to peerDependencies I've got huge module with all 3 packages inlined. I've read a few issues that seemed similar and add following records to the externals section:

    "jquery": "jQuery", 
    "jszip": "JSZip",
    "devextreme": "DevExtreme"

After that jQuery and JSzip have disappeared but DevExtreme is still there (and I don't understand why) and devextreme-angular of course too (this is second part of my question: I can't find its module name).
It'll be great if you will make it clear, I really appreciate any help you can provide

P.S. DevExtreme team have some docs about Rollup usage which I already follow (I use long paths in my imports) and it doesn't seem have any affect.

How To Reproduce

Just add jQuery, JSzip, DevExtreme and devextreme-angular to your lib as peerDependencies.

Expected Behaviour

Flat modules with only my code.

Version Information

ng-packagr: v1.4.1
node: v8.4.0
@angular: v4.4.5
rxjs: "5.4.3"
zone.js: "0.8.14"
devextreme-angular: "17.1.7",
devextreme: "17.1.17",
jquery: "3.2.1",
jszip: "3.1.4"
@dherges
Copy link
Contributor

dherges commented Oct 18, 2017

It's the symbol on the global scope. You can find it by looking into the dist javascript files of a lirary, e.g.:

#135 (comment)

Also...

(closing as duplicate)

@dherges dherges closed this as completed Oct 18, 2017
@github-actions
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

This action has been performed automatically by a bot.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

2 participants