Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update supported range of node versions #1996

Merged
merged 2 commits into from
Jun 3, 2021
Merged

fix: update supported range of node versions #1996

merged 2 commits into from
Jun 3, 2021

Conversation

sibiraj-s
Copy link
Member

I'm submitting a...

[x] Bug Fix
[ ] Feature
[ ] Other (Refactoring, Added tests, Documentation, ...)

Checklist

  • Commit Messages follow the Conventional Commits pattern
    • A feature commit message is prefixed "feat:"
    • A bugfix commit message is prefixed "fix:"
  • Tests for the changes have been added

Description

This is to align the supported nodejs versions with angular/cli v12.0.3.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@sibiraj-s
Copy link
Member Author

I am not sure whether it should be same as angular cli. which has ^12.14.1 || >=14.0.0, that drops nodejs 13 support here.

package.json Outdated Show resolved Hide resolved
Co-authored-by: Alan Agius <alan.agius4@gmail.com>
@sibiraj-s
Copy link
Member Author

done @alan-agius4

Copy link
Member

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@alan-agius4 alan-agius4 merged commit 1064bea into ng-packagr:master Jun 3, 2021
@sibiraj-s sibiraj-s deleted the patch-1 branch June 3, 2021 07:04
@github-actions
Copy link

github-actions bot commented Jul 4, 2021

This PR has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

This action has been performed automatically by a bot.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants