Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add watch options with ignore #2042

Closed
wants to merge 3 commits into from

Conversation

kurtaqui
Copy link

@kurtaqui kurtaqui commented Aug 9, 2021

I'm submitting a...

[ ] Bug Fix
[x] Feature
[ ] Other (Refactoring, Added tests, Documentation, ...)

Checklist

  • Commit Messages follow the Conventional Commits pattern
    • A feature commit message is prefixed "feat:"
    • A bugfix commit message is prefixed "fix:"
  • Tests for the changes have been added

Description

Handles #1723

Can ignore any file or directories specified inside ignore property inside watchOptions solves the issue of watching linked libraries.

Does this PR introduce a breaking change?

[x] Yes
[ ] No

Users that want to ignore node_modules need to add;

watchOptions: {
  ignored: /node_modules/
}

@kurtaqui
Copy link
Author

being solved with #2043

@github-actions
Copy link

This PR has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

This action has been performed automatically by a bot.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 15, 2021
@alan-agius4 alan-agius4 reopened this Oct 19, 2021
alan-agius4 added a commit that referenced this pull request Oct 19, 2021
With this change, we now only watch for files which are dependencies in the compilation. Previously, we watch the entire directory.

Closes #1829, closes #2042 and closes #1723
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants