fix: Virtual scroll scrollTop value calculation

ng-select · Sep 30, 2017 · 1b0ed3c · 1b0ed3c
1 parent e95a60c
commit 1b0ed3c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/src/lib/src/ng-select.component.html b/src/lib/src/ng-select.component.html
@@ -47,7 +47,7 @@
     </span>
 </div>
 
-<div class="as-menu-outer" [ngStyle]="{'visibility': isOpen ? 'visible' : 'hidden'}">
+<div class="as-menu-outer">
     <virtual-scroll role="listbox" class="as-menu" [bufferAmount]="4" [items]="itemsList.filteredItems" (update)="viewPortItems = $event">
         <div class="as-option" role="option" (click)="toggle(item)" (mouseover)="onItemHover(item)"
              *ngFor="let item of viewPortItems;"

diff --git a/src/lib/src/virtual-scroll.component.ts b/src/lib/src/virtual-scroll.component.ts
@@ -177,11 +177,12 @@ export class VirtualScrollComponent implements OnInit, OnChanges, OnDestroy {
             return;
         }
 
-        let d = this.calculateDimensions();
+        const d = this.calculateDimensions();
+        const buffer = Math.floor(d.viewHeight / d.childHeight) - 1;
         el.scrollTop = (Math.floor(index / d.itemsPerRow) * d.childHeight)
-            - (d.childHeight * Math.min(index, this.bufferAmount));
+            - (d.childHeight * Math.min(index, buffer));
         this.refresh();
-    }
+    };
 
     private refreshHandler = () => {
         this.refresh();