fix: increase dropdown container height

ng-select · Sep 24, 2017 · 1c30d71 · 1c30d71
1 parent cede554
commit 1c30d71
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 9 deletions.
diff --git a/src/lib/src/ng-select.component.scss b/src/lib/src/ng-select.component.scss
@@ -173,15 +173,15 @@ ng-select {
     box-shadow: 0 1px 0 rgba(0, 0, 0, 0.06);
     box-sizing: border-box;
     margin-top: -1px;
-    max-height: 200px;
+    max-height: 242px;
     position: absolute;
     top: 100%;
     width: 100%;
     z-index: 1;
     -webkit-overflow-scrolling: touch;
   }
   .as-menu {
-    max-height: 198px;
+    max-height: 240px;
     overflow-y: auto;
   }
   .as-option {

diff --git a/src/lib/src/ng-select.component.ts b/src/lib/src/ng-select.component.ts
@@ -81,22 +81,19 @@ export class NgSelectComponent implements OnInit, ControlValueAccessor {
     filterValue: string = null;
 
     private _value: NgOption | NgOption[] = null;
-
     private _openClicked = false;
-    private _items: NgOption[];
     private propagateChange = (_: NgOption) => { };
 
     constructor(private changeDetectorRef: ChangeDetectorRef, private elementRef: ElementRef) {
     }
 
     @Input()
-    get items(): any[] {
-        return this._items;
+    get items(): NgOption[] {
+        return this.itemsList.items;
     }
 
-    set items(items: any[]) {
-        this._items = items || [];
-        this.itemsList = new ItemsList(this._items, this.multiple);
+    set items(items: NgOption[]) {
+        this.itemsList = new ItemsList(items || [], this.multiple);
 
         if (this.isTypeahead()) {
             this.handleItemsChange();