fix: don't set group as selected when all it's children selected

ng-select · Aug 31, 2018 · 5f63d13 · 5f63d13
1 parent f67fb61
commit 5f63d13
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 18 deletions.
diff --git a/src/ng-select/items-list.spec.ts b/src/ng-select/items-list.spec.ts
@@ -109,20 +109,6 @@ describe('ItemsList', () => {
                 expect(list.filteredItems.length).toBe(3);
             });
 
-            it('should select group when all group children are selected', () => {
-                cmp.hideSelected = true;
-                cmp.groupBy = 'groupKey';
-                list.setItems([
-                    { label: 'K1', val: 'V1', groupKey: 'G1' },
-                    { label: 'K2', val: 'V2', groupKey: 'G1' },
-                ]);
-                list.select(list.items[1]); // K1
-                list.select(list.items[2]); // K2
-
-                expect(list.selectedItems.length).toBe(1);
-                expect(list.selectedItems[0].label).toBe('G1');
-            });
-
             it('should remove all group and group children items if group is selected when hideSelected=true', () => {
                 cmp.hideSelected = true;
                 cmp.groupBy = 'groupKey';

diff --git a/src/ng-select/selection-model.ts b/src/ng-select/selection-model.ts
@@ -21,10 +21,6 @@ export class SelectionModel {
                 const childrenCount = item.parent.children.length;
                 const selectedCount = item.parent.children.filter(x => x.selected).length;
                 item.parent.selected = childrenCount === selectedCount;
-                if (item.parent.selected && groupAsModel) {
-                    this._removeChildren(item.parent);
-                    this._selected = [...this._selected, item.parent];
-                }
             } else if (item.children) {
                 this._setChildrenSelectedState(item.children, true);
                 this._removeChildren(item);