fix: mark for check when closing dropdown (#140)

fixes #138
ng-select · Nov 26, 2017 · 78ff661 · 78ff661
1 parent 63d9f70
commit 78ff661
Show file tree

Hide file tree

Showing 10 changed files with 20 additions and 9 deletions.
diff --git a/demo/app/app.component.ts b/demo/app/app.component.ts
@@ -1,6 +1,6 @@
 import '../style/styles.scss';
 
-import { Component } from '@angular/core';
+import { Component, ChangeDetectionStrategy } from '@angular/core';
 import { ActivatedRoute, NavigationEnd, Router } from '@angular/router';
 import 'rxjs/add/operator/filter';
 import 'rxjs/add/operator/map';
@@ -9,7 +9,8 @@ import { Title } from '@angular/platform-browser';
 
 @Component({
     selector: 'demo-app',
-    templateUrl: './app.component.html'
+    templateUrl: './app.component.html',
+    changeDetection: ChangeDetectionStrategy.OnPush,
 })
 export class AppComponent {
 

diff --git a/demo/app/examples/bindings.component.ts b/demo/app/examples/bindings.component.ts
@@ -1,7 +1,8 @@
-import {Component} from '@angular/core';
+import { Component, ChangeDetectionStrategy } from '@angular/core';
 
 @Component({
     selector: 'select-bindings',
+    changeDetection: ChangeDetectionStrategy.OnPush,
     template: `
         <label>Bind to default <b>label</b>, <b>object</b> bindings</label>
         ---html,true

diff --git a/demo/app/examples/custom-templates.component.ts b/demo/app/examples/custom-templates.component.ts
@@ -1,7 +1,8 @@
-import { Component } from '@angular/core';
+import { Component, ChangeDetectionStrategy } from '@angular/core';
 
 @Component({
     selector: 'select-with-templates',
+    changeDetection: ChangeDetectionStrategy.OnPush,
     template: `
         <label>Custom label</label>
         ---html,true

diff --git a/demo/app/examples/events.component.ts b/demo/app/examples/events.component.ts
@@ -1,4 +1,4 @@
-import { Component } from '@angular/core';
+import { Component, ChangeDetectionStrategy } from '@angular/core';
 
 
 interface AngSelectEvent {
@@ -8,6 +8,7 @@ interface AngSelectEvent {
 
 @Component({
     selector: 'select-events',
+    changeDetection: ChangeDetectionStrategy.OnPush,
     template: `
         <div id="s1"></div>
         <label>Open, close, focus, blur, change events</label>

diff --git a/demo/app/examples/multi.component.ts b/demo/app/examples/multi.component.ts
@@ -1,9 +1,10 @@
-import { Component } from '@angular/core';
+import { Component, ChangeDetectionStrategy } from '@angular/core';
 import { NgOption } from '@ng-select/ng-select';
 import { HttpClient } from '@angular/common/http';
 import { Observable } from 'rxjs/Observable';
 
 @Component({
+    changeDetection: ChangeDetectionStrategy.OnPush,
     template: `
         <label>Select multiple elements</label>
         ---html,true

diff --git a/demo/app/examples/reactive-forms.component.ts b/demo/app/examples/reactive-forms.component.ts
@@ -7,6 +7,7 @@ import { DataService } from '../shared/data.service';
 
 @Component({
     selector: 'reactive-forms',
+    changeDetection: ChangeDetectionStrategy.OnPush,
     template: `
         <form [formGroup]="heroForm" novalidate>
             ---html

diff --git a/demo/app/examples/search.component.ts b/demo/app/examples/search.component.ts
@@ -1,4 +1,4 @@
-import { Component, EventEmitter } from '@angular/core';
+import { Component, EventEmitter, ChangeDetectionStrategy } from '@angular/core';
 import { HttpClient } from '@angular/common/http';
 import { Observable } from 'rxjs/Observable';
 import 'rxjs/add/operator/distinctUntilChanged';
@@ -9,6 +9,7 @@ import { DataService } from '../shared/data.service';
 
 @Component({
     selector: 'select-search',
+    changeDetection: ChangeDetectionStrategy.OnPush,
     template: `
         <h5>Default search</h5>
         <hr>

diff --git a/demo/app/examples/tags.component.ts b/demo/app/examples/tags.component.ts
@@ -1,9 +1,10 @@
-import { Component, EventEmitter } from '@angular/core';
+import { Component, EventEmitter, ChangeDetectionStrategy } from '@angular/core';
 import { HttpClient } from '@angular/common/http';
 import { Observable } from 'rxjs/Observable';
 
 @Component({
     selector: 'select-tags',
+    changeDetection: ChangeDetectionStrategy.OnPush,
     template: `
         <label>Default tags</label>
         ---html,true

diff --git a/demo/app/examples/virtual-scroll.component.ts b/demo/app/examples/virtual-scroll.component.ts
@@ -1,8 +1,9 @@
-import { Component } from '@angular/core';
+import { Component, ChangeDetectionStrategy } from '@angular/core';
 import { HttpClient } from '@angular/common/http';
 
 @Component({
     selector: 'select-tags',
+    changeDetection: ChangeDetectionStrategy.OnPush,
     template: `
         <p>
             By default ng-select enables virtual scroll for more 20 items. You can turn it off by setting disableVirtualScroll to true. 

diff --git a/src/ng-select/ng-select.component.ts b/src/ng-select/ng-select.component.ts
@@ -425,10 +425,12 @@ export class NgSelectComponent implements OnInit, OnDestroy, OnChanges, AfterVie
 
             if (this.isFocused) {
                 this.onInputBlur();
+                this.changeDetectorRef.markForCheck();
             }
 
             if (this.isOpen) {
                 this.close();
+                this.changeDetectorRef.markForCheck();
             }
         };