feat: open dropdown on enter

closes #508
ng-select · May 1, 2018 · aeed111 · aeed111
1 parent bcf3340
commit aeed111
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/src/ng-select/ng-select.component.spec.ts b/src/ng-select/ng-select.component.spec.ts
@@ -1147,6 +1147,20 @@ describe('NgSelectComponent', function () {
                 expect(findByLabel).toHaveBeenCalledWith('vil')
             }));
         });
+
+        describe('enter', () => {
+            it('should open dropdown when it is closed', () => {
+                triggerKeyDownEvent(getNgSelectElement(fixture), KeyCode.Enter);
+                expect(select.isOpen).toBe(true);
+            });
+
+            it('should select option and close dropdown', () => {
+                triggerKeyDownEvent(getNgSelectElement(fixture), KeyCode.Space);
+                triggerKeyDownEvent(getNgSelectElement(fixture), KeyCode.Enter);
+                expect(select.selectedItems[0].value).toEqual(fixture.componentInstance.cities[0])
+                expect(select.isOpen).toBe(false);
+            });
+        });
     });
 
     describe('Outside click', () => {

diff --git a/src/ng-select/ng-select.component.ts b/src/ng-select/ng-select.component.ts
@@ -687,6 +687,8 @@ export class NgSelectComponent implements OnDestroy, OnChanges, AfterViewInit, C
             } else if (this.addTag) {
                 this.selectTag();
             }
+        } else {
+            this.open();
         }
         $event.preventDefault();
         $event.stopPropagation();