fix: show type to search on typeahead (#416)

fixes #405
ng-select · Apr 6, 2018 · ed1b3d6 · ed1b3d6
1 parent aff8468
commit ed1b3d6
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 1 deletion.
diff --git a/demo/app/examples/search.component.ts b/demo/app/examples/search.component.ts
@@ -51,6 +51,7 @@ import { DataService, Person } from '../shared/data.service';
                    bindLabel="name"
                    [addTag]="true"
                    [multiple]="true"
+                   [hideSelected]="true"
                    [typeahead]="peopleTypeahead"
                    [(ngModel)]="selectedPersons">
         </ng-select>

diff --git a/src/ng-select/ng-select.component.spec.ts b/src/ng-select/ng-select.component.spec.ts
@@ -1897,6 +1897,7 @@ describe('NgSelectComponent', function () {
                     `<ng-select [items]="cities"
                         [typeahead]="filter"
                         bindLabel="name"
+                        [hideSelected]="hideSelected"
                         [(ngModel)]="selectedCity">
                     </ng-select>`);
             });
@@ -1953,6 +1954,16 @@ describe('NgSelectComponent', function () {
                 tickAndDetectChanges(fixture);
                 expect(fixture.componentInstance.select.isLoading).toBeFalsy();
             }));
+
+            it('should open dropdown when hideSelected=true and no items to select', fakeAsync(() => {
+                fixture.componentInstance.hideSelected = true;
+                fixture.componentInstance.cities = [];
+                fixture.componentInstance.selectedCity = null;
+                tickAndDetectChanges(fixture);
+                fixture.componentInstance.filter.subscribe();
+                fixture.componentInstance.select.open();
+                expect(fixture.componentInstance.select.isOpen).toBeTruthy();
+            }));
         });
     });
 
@@ -2366,6 +2377,7 @@ class NgSelectTestCmp {
     filter = new Subject<string>();
     searchFn: (term: string, item: any) => boolean = null;
     selectOnTab = true;
+    hideSelected = false;
 
     citiesLoading = false;
     selectedCityId: number;

diff --git a/src/ng-select/ng-select.component.ts b/src/ng-select/ng-select.component.ts
@@ -290,7 +290,10 @@ export class NgSelectComponent implements OnDestroy, OnChanges, AfterViewInit, C
     }
 
     open() {
-        if (this.isDisabled || this.isOpen || this.itemsList.maxItemsSelected || this.itemsList.noItemsToSelect) {
+        if (this.isDisabled || this.isOpen || this.itemsList.maxItemsSelected) {
+            return;
+        }
+        if (!this._isTypeahead && (this.itemsList.noItemsToSelect)) {
             return;
         }
         this.isOpen = true;