Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: focus filter on clear #110

Merged
merged 1 commit into from
Oct 28, 2017
Merged

fix: focus filter on clear #110

merged 1 commit into from
Oct 28, 2017

Conversation

anjmao
Copy link
Member

@anjmao anjmao commented Oct 28, 2017

fixes #93

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 88.549% when pulling 0d51c27 on cursor-focus-fix into fa21804 on master.

anjmao
anjmao commented Oct 28, 2017
View reviewed changes
src/ng-select/ng-select.component.scss
.ng-control .ng-value-container .ng-input {
opacity: 0;
}
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not needed because we should show focused filter when clear is clicked or select is focused. This is default behaviour for inputs, then you use tab to focus input it will get cursor focus so you can start writing text.

@anjmao anjmao merged commit 0faef55 into master Oct 28, 2017
@varnastadeus varnastadeus deleted the cursor-focus-fix branch December 5, 2017 06:27
jakemdunn pushed a commit to jakemdunn/ng-select that referenced this pull request Oct 16, 2018
@anjmao
fix: focus filter on clear (ng-select#110)
c5e111d 
fixes ng-select#93
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@varnastadeus varnastadeus varnastadeus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[single select] cursor disappear
3 participants
@anjmao @coveralls @varnastadeus