Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove unnecessary FormsModule. #112

Merged
merged 1 commit into from
Oct 29, 2017
Merged

feat: remove unnecessary FormsModule. #112

merged 1 commit into from
Oct 29, 2017

Conversation

aitboudad
Copy link
Contributor

This will leave users to choose between FormsModule or ReactiveFormsModule.

@anjmao
Copy link
Member

anjmao commented Oct 29, 2017

@aitboudad Thanks! Good point :)

@anjmao anjmao merged commit 4e211cb into ng-select:master Oct 29, 2017
@aitboudad aitboudad deleted the forms-module branch October 29, 2017 15:09
jakemdunn pushed a commit to jakemdunn/ng-select that referenced this pull request Oct 16, 2018
@aitboudad @anjmao
fix: remove unnecessary FormsModule. (ng-select#112)
40bd1ba
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aitboudad @anjmao