Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ng option component #113

Merged
merged 3 commits into from
Oct 31, 2017
Merged

Ng option component #113

merged 3 commits into from
Oct 31, 2017

Conversation

anjmao
Copy link
Member

@anjmao anjmao commented Oct 29, 2017

This change will allow to have simple select like this one

<ng-select [(ngModel)]="agree">
  <ng-option [value]="true">Yes</ng-option>
  <ng-option [value]="false">No</ng-option>
</ng-select>

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 88.743% when pulling b764d35 on ng-option-component into 4e211cb on master.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling e8a5239 on ng-option-component into ** on master**.

@anjmao anjmao merged commit 6d841ef into master Oct 31, 2017
@anjmao anjmao deleted the ng-option-component branch October 31, 2017 14:19
jakemdunn pushed a commit to jakemdunn/ng-select that referenced this pull request Oct 16, 2018
@anjmao
feat: ng-option support for simple dropdowns (ng-select#113)
966c75c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@varnastadeus varnastadeus Awaiting requested review from varnastadeus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@anjmao @coveralls