Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for simple arrays #129

Merged
merged 2 commits into from
Nov 20, 2017
Merged

feat: support for simple arrays #129

merged 2 commits into from
Nov 20, 2017

Conversation

varnastadeus
Copy link
Member

closes #100

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 88.136% when pulling 625b24f on simple-arrays into 767831e on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 88.347% when pulling e69a413 on simple-arrays into 767831e on master.

@@ -101,6 +102,9 @@ export class NgSelectComponent implements OnInit, OnDestroy, OnChanges, AfterVie
filterValue: string = null;

private _ngModel = null;
private _simple = false;
private _defaultLabel = 'label';
private _defaultValue = 'value';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this

@anjmao anjmao merged commit 9504ad5 into master Nov 20, 2017
@anjmao anjmao deleted the simple-arrays branch November 20, 2017 16:29
jakemdunn pushed a commit to jakemdunn/ng-select that referenced this pull request Oct 16, 2018
* feat: support for simple arrays
closes ng-select#100
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support simple arrays
3 participants