Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix custom tags insertion #135

Merged
merged 3 commits into from
Nov 26, 2017
Merged

fix custom tags insertion #135

merged 3 commits into from
Nov 26, 2017

Conversation

anjmao
Copy link
Member

@anjmao anjmao commented Nov 22, 2017

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 88.384% when pulling ad591fa on fix-tags into 79d042e on master.

@anjmao anjmao changed the title add data service fix custom tags insertion Nov 25, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+1.9%) to 90.323% when pulling 5ba830a on fix-tags into 79d042e on master.

@anjmao
Copy link
Member Author

anjmao commented Nov 26, 2017

#124

@anjmao anjmao merged commit 63d9f70 into master Nov 26, 2017
@anjmao anjmao deleted the fix-tags branch November 26, 2017 10:52
@varnastadeus
Copy link
Member

varnastadeus commented Nov 26, 2017 •
edited

@anjmao where are the tests?

@varnastadeus
Copy link
Member

varnastadeus commented Nov 26, 2017 •
edited

  1. select show selected values, even if they don't match filter term
  2. opening filter, shows last added tag

screen shot 2017-11-26 at 16 30 10

jakemdunn pushed a commit to jakemdunn/ng-select that referenced this pull request Oct 16, 2018
@anjmao
fix: custom tags insertion on multiselect (ng-select#135)
780d7a2 
fixes ng-select#124
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@varnastadeus varnastadeus Awaiting requested review from varnastadeus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@anjmao @coveralls @varnastadeus