Header footer templates #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varnastadeus
requested changes
Jan 16, 2018
| @@ -60,12 +84,29 @@ export class SelectWithTemplatesComponent { | |||
|
|
|||
| cities2 = JSON.parse(JSON.stringify(this.cities)); | |||
| cities3 = JSON.parse(JSON.stringify(this.cities)); | |||
| cities4 = JSON.parse(JSON.stringify(this.cities)); | |||
There was a problem hiding this comment.
why not just slice?
cities4 = this.cities.slice();| @@ -262,6 +262,16 @@ $color-selected: #f5faff; | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| .ng-dropdown-header { | |||
| border-bottom: 1px solid #ccc; | |||
There was a problem hiding this comment.
not sure if predefined border is good idea
|
good job! 👍 |
|
@varnastadeus please merge it if its good, I am waiting for this update 👍 |
varnastadeus
approved these changes
Jan 17, 2018
|
@arun-maddheshia Check it out and let me know if it solves you problem. |
jakemdunn
pushed a commit
to jakemdunn/ng-select
that referenced
this pull request
Oct 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #184