feat: allow open menu if max items limit is reached #2054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
windischb
changed the title
|
@windischb thanks for your contribution. Looking back at the feature I would say this should be the default behavior as it improves UX. Can you change the code without introducing new property? Also, we should consider whether to release this under breaking change 🤔 |
|
@varnastadeus of course! |
varnastadeus
previously approved these changes
May 27, 2022
varnastadeus
force-pushed
the
allowOpenOnMaxItemsReached
branch
from
134ea3c
to
d81e599
Compare
|
🎉 This PR is included in version 8.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
As we have the need to open the menu, even if the maxSelectedItems limit is reached, i have added an option for that.
There is also an open Issue(#1447) which this PR fixes.