Close dropdown on select by default #226

anjmao · 2018-02-02T06:58:11Z

coveralls · 2018-02-02T07:05:08Z

Coverage increased (+0.3%) to 90.943% when pulling 579ca6d on dropdown-items into 0831789 on master.

varnastadeus · 2018-02-02T18:06:11Z

src/ng-select/items-list.ts

-    private _multiple = false;
-    private _bindLabel: string;
+
+    constructor(private cmp: NgSelectComponent) {}


maybe rename to ngSelect

closes ng-select#222

anjmao added 3 commits February 2, 2018 08:30

feat: add closeOnSelect input

f1f3958

add unit tests

a9362d7

remove uneeded param

6996298

remove uneeded virtual scroll code

c19bc40

anjmao requested a review from varnastadeus February 2, 2018 07:58

varnastadeus reviewed Feb 2, 2018

View reviewed changes

anjmao added 2 commits February 2, 2018 20:09

rename to more clear naming

1aee061

remove uneeded variable

579ca6d

varnastadeus approved these changes Feb 2, 2018

View reviewed changes

anjmao merged commit 77d36ca into master Feb 2, 2018

anjmao deleted the dropdown-items branch February 2, 2018 18:22

jakemdunn pushed a commit to jakemdunn/ng-select that referenced this pull request Oct 16, 2018

feat: Close dropdown on select by default (ng-select#226)

5600626

closes ng-select#222

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Close dropdown on select by default #226

Close dropdown on select by default #226

anjmao commented Feb 2, 2018

coveralls commented Feb 2, 2018 •

edited

varnastadeus Feb 2, 2018

Close dropdown on select by default #226

Close dropdown on select by default #226

Conversation

anjmao commented Feb 2, 2018

coveralls commented Feb 2, 2018 • edited

varnastadeus Feb 2, 2018

Choose a reason for hiding this comment

coveralls commented Feb 2, 2018 •

edited