destroy dropdown panel on close #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anjmao
changed the title
anjmao
changed the title
varnastadeus
requested changes
Feb 25, 2018
| (empty && this._isTypeahead && this.filterValue && !this.isLoading); | ||
| return ((empty && !this._isTypeahead && !this.loading) || | ||
| (empty && this._isTypeahead && this.filterValue && !this.isLoading)) && | ||
| !this.showAddTag(); |
src/ng-select/ng-select.component.ts
Outdated
| @@ -422,6 +406,13 @@ export class NgSelectComponent implements OnInit, OnDestroy, OnChanges, AfterVie | |||
| } | |||
| } | |||
|
|
|||
| focusSearchInput() { | |||
| setTimeout(() => { | |||
| @@ -0,0 +1,279 @@ | |||
| import { | |||
There was a problem hiding this comment.
name it ng-dropdown-panel or just ng-dropdown since all such files have ng prefix
| private _zone: NgZone, | ||
| private _virtualScrollService: VirtualScrollService | ||
| ) { | ||
| this._inputElementRef = _ngSelect.elementRef; |
There was a problem hiding this comment.
isn't it ng-select elementRef?
| @Output() positionChange = new EventEmitter(); | ||
|
|
||
| @ViewChild('content', { read: ElementRef }) contentElementRef: ElementRef; | ||
| @ViewChild('scroll', { read: ElementRef }) scrollElementRef: ElementRef; |
There was a problem hiding this comment.
add scrollEnd event and lazy loading example from #267 pr
| } | ||
| } | ||
|
|
||
| ngOnChanges(changes: SimpleChanges) { |
| } | ||
|
|
||
| refresh() { | ||
| if (IS_TEST) { |
There was a problem hiding this comment.
can anything else can be done here?
| import { WindowService } from './window.service'; | ||
|
|
||
| @Component({ | ||
| providers: [VirtualScrollService], |
There was a problem hiding this comment.
Here each component instance will have separate instance of VirtualScrollService, not sure if this is a good idea
| const IS_TEST = process.env.NODE_ENV === 'TEST'; | ||
|
|
||
| @Component({ | ||
| providers: [VirtualScrollService], |
There was a problem hiding this comment.
Here each component instance will have separate VirtualScrollService instance, not sure if it is good idea
varnastadeus
approved these changes
Feb 25, 2018
|
Looks nice, great job! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR dropdown panel will be added to the DOM only when dropdown is opened.