fix(tag): tag should be same type as items #322

varnastadeus · 2018-03-06T11:31:15Z

fixes #315

anjmao · 2018-03-06T12:51:52Z

src/ng-select/ng-select.component.ts

@@ -126,6 +126,7 @@ export class NgSelectComponent implements OnDestroy, OnChanges, AfterViewInit, C
    private _defaultLabel = 'label';
    private _defaultValue = 'value';
    private _typeaheadLoading = false;
+    private _simple: boolean;


rename to _isPrimitive

anjmao

👍

coveralls · 2018-03-07T00:51:17Z

Coverage decreased (-0.03%) to 92.023% when pulling 4181780 on simple-tagging-fix into 3525787 on master.

fixes ng-select#315

fix(tag): tag should be same type as items

62bc7ad

fixes #315

varnastadeus requested a review from anjmao March 6, 2018 11:31

refactor

eb6460c

anjmao reviewed Mar 6, 2018

View reviewed changes

varnastadeus added 2 commits March 6, 2018 14:55

rename

ac07bdc

use typeof instead instanceOf

4181780

anjmao approved these changes Mar 6, 2018

View reviewed changes

varnastadeus merged commit 25a3245 into master Mar 6, 2018

varnastadeus deleted the simple-tagging-fix branch March 6, 2018 14:04

jakemdunn pushed a commit to jakemdunn/ng-select that referenced this pull request Oct 16, 2018

fix(tag): tag should be same type as items (ng-select#322)

47286f5

fixes ng-select#315

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(tag): tag should be same type as items #322

fix(tag): tag should be same type as items #322

varnastadeus commented Mar 6, 2018

anjmao Mar 6, 2018

anjmao left a comment

coveralls commented Mar 7, 2018 •

edited

fix(tag): tag should be same type as items #322

fix(tag): tag should be same type as items #322

Conversation

varnastadeus commented Mar 6, 2018

anjmao Mar 6, 2018

Choose a reason for hiding this comment

anjmao left a comment

Choose a reason for hiding this comment

coveralls commented Mar 7, 2018 • edited

coveralls commented Mar 7, 2018 •

edited