Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto position dropdown #382

Merged
merged 9 commits into from
Mar 29, 2018
Merged

Auto position dropdown #382

merged 9 commits into from
Mar 29, 2018

Conversation

anjmao
Copy link
Member

@anjmao anjmao commented Mar 23, 2018 •
edited

@coveralls
Copy link

coveralls commented Mar 23, 2018 •
edited

Coverage Status

Coverage increased (+0.2%) to 93.609% when pulling 487035b on auto-position-dropdown into fa06772 on master.

varnastadeus
varnastadeus requested changes Mar 28, 2018
View reviewed changes
src/ng-select/ng-dropdown-panel.component.ts Outdated
this._currentPosition = this._calculateCurrentPosition(dropdownEl);
const selectEl: HTMLElement = this._selectElementRef.nativeElement;
if (this._currentPosition === 'top') {
dropdownEl.classList.add(TOP_CSS_CLASS);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use renderer here?

@anjmao anjmao merged commit c75595d into master Mar 29, 2018
@anjmao anjmao deleted the auto-position-dropdown branch March 29, 2018 05:09
jakemdunn pushed a commit to jakemdunn/ng-select that referenced this pull request Oct 16, 2018
@anjmao
feat: auto position dropdown by default (ng-select#382)
a8d8409 
fixes ng-select#367 
fixes ng-select#256 
fixes ng-select#306
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@varnastadeus varnastadeus varnastadeus requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@anjmao @coveralls @varnastadeus