Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: close dropdown on outside click #465

Merged
merged 3 commits into from
Apr 17, 2018
Merged

fix: close dropdown on outside click #465

merged 3 commits into from
Apr 17, 2018

Conversation

anjmao
Copy link
Member

@anjmao anjmao commented Apr 17, 2018

fixes #453
fixes #313

@coveralls
Copy link

coveralls commented Apr 17, 2018 •
edited

Coverage Status

Coverage decreased (-0.1%) to 93.306% when pulling 82887a7 on close-dropdown-fix into 852643f on master.

@anjmao anjmao merged commit 8d8f2a5 into master Apr 17, 2018
@anjmao anjmao deleted the close-dropdown-fix branch April 17, 2018 15:37
jakemdunn pushed a commit to jakemdunn/ng-select that referenced this pull request Oct 16, 2018
@anjmao
fix: close dropdown on outside click (ng-select#465)
f168c4a 
fixes ng-select#453 
fixes ng-select#313 

Previously ng-select dropdown close was handled by clicking on invisible overlay, but it causes some issues. This approach uses global document mousedown event listener to determine when to close dropdown.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@varnastadeus varnastadeus varnastadeus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@anjmao @coveralls @varnastadeus