Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: emit event while removing using backspace #565

Merged
merged 1 commit into from
May 18, 2018
Merged

fix: emit event while removing using backspace #565

merged 1 commit into from
May 18, 2018

Conversation

varnastadeus
Copy link
Member

fixes #564

@varnastadeus varnastadeus requested a review from anjmao May 18, 2018 11:06
@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 93.019% when pulling 04f47cb on improvments into 38c4edd on master.

@varnastadeus varnastadeus merged commit 433f91b into master May 18, 2018
@varnastadeus varnastadeus deleted the improvments branch May 18, 2018 14:50
@orozco1582
Copy link

@varnastadeus are you going to merge this in v1.5 for compatibility? please say yes, thanks :)

varnastadeus added a commit that referenced this pull request May 18, 2018
@varnastadeus
fix: emit event while removing using backspace (#565)
b698bdf 
fixes #564
jakemdunn pushed a commit to jakemdunn/ng-select that referenced this pull request Oct 16, 2018
@varnastadeus
fix: emit event while removing using backspace (ng-select#565)
5ed6a40 
fixes ng-select#564
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anjmao anjmao Awaiting requested review from anjmao

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The (remove) output is not being triggered when item removed with keyboard (backspace)
3 participants
@varnastadeus @coveralls @orozco1582