Bugfix: keep filter status consistent with items updates #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coreprocess
commented
May 26, 2018
src/ng-select/ng-select.component.ts
Outdated
| if (this._isTypeahead) { | ||
| this.typeahead.next(this.filterValue); | ||
| } else if(this.isOpen) { | ||
| this.itemsList.filter(this.filterValue); |
There was a problem hiding this comment.
This is the real bugfix regarding our use cases.
coreprocess
commented
May 26, 2018
src/ng-select/ng-select.component.ts
Outdated
| @@ -483,7 +483,11 @@ export class NgSelectComponent implements OnDestroy, OnChanges, AfterViewInit, C | |||
| if (items.length > 0 && this.hasValue) { | |||
| this.itemsList.mapSelectedItems(); | |||
| } | |||
|
|
|||
| if (this._isTypeahead) { | |||
| this.typeahead.next(this.filterValue); | |||
There was a problem hiding this comment.
Not sure, if this is required.
anjmao
requested changes
May 28, 2018
src/ng-select/ng-select.component.ts
Outdated
|
|
||
| if (this._isTypeahead) { | ||
| this.typeahead.next(this.filterValue); | ||
| } else if (this.isOpen) { |
There was a problem hiding this comment.
Thanks for contributing. In this case typeahead is not needed so you need to check it also you need to check if filterValue was actually set.
if (this.isOpen && isDefined(this.filterValue) && !this._isTypeahead) {
this.itemsList.filter(this.filterValue);
}PS. Add unit test for this case when dropdown is opened and filter value is set. Thanks.
There was a problem hiding this comment.
Thanks for the review. I will get back to you ASAP.
|
Do you plan to add that fix for 1.x version? |
jakemdunn
pushed a commit
to jakemdunn/ng-select
that referenced
this pull request
Oct 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Item list updates result in a reset of the filtered item list. This will result in an inconsistent state in case the ng-select is open while item list updates arrive.
This PR corrects the problem.