Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow to use compareWith fn when bindValue is used #586

Merged
merged 1 commit into from
May 30, 2018
Merged

fix: allow to use compareWith fn when bindValue is used #586

merged 1 commit into from
May 30, 2018

Conversation

anjmao
Copy link
Member

@anjmao anjmao commented May 28, 2018

fixes #582

@anjmao anjmao requested a review from varnastadeus May 28, 2018 13:45
@coveralls
Copy link

Coverage Status

Coverage increased (+0.8%) to 94.063% when pulling dbdbe23 on fix-compare-with-fn into 291682d on master.

This was referenced May 29, 2018
Closed
Closed
@anjmao anjmao merged commit 7a3dfb3 into master May 30, 2018
@varnastadeus varnastadeus deleted the fix-compare-with-fn branch May 30, 2018 15:14
jakemdunn pushed a commit to jakemdunn/ng-select that referenced this pull request Oct 16, 2018
@anjmao
fix: allow to use compareWith fn when bindValue is used (ng-select#586)
485d5e4 
closes ng-select#535
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@varnastadeus varnastadeus varnastadeus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CompareWith] issue
3 participants
@anjmao @coveralls @varnastadeus