Allow form to submit when enter is pressed on a closed ng-select #878

jakemdunn · 2018-10-16T16:38:42Z

Resolves #877 - Adds an openOnEnter parameter that defaults to true, and can be set in the global config. This keeps the current functionality while providing a route to enable the more accessible behavior globally.

… pressed on a closed select.

varnastadeus

Thanks for contribution! I added comments about some small changes to be made before merge

src/ng-select/ng-select.component.ts

src/ng-select/ng-select.types.ts

coveralls · 2018-10-17T13:13:47Z

Coverage decreased (-0.03%) to 94.399% when pulling fd47b27 on jakemdunn:master into d022c85 on ng-select:master.

src/ng-select/ng-select.component.ts

closes ng-select#878

jakemdunn added 2 commits October 16, 2018 10:08

Can set openOnEnter to false to allow form submission when enter is…

f759ae6

… pressed on a closed select.

Added openOnEnter parameter to documentation

6eae524

varnastadeus requested changes Oct 17, 2018

View reviewed changes

src/ng-select/ng-select.component.ts Outdated Show resolved Hide resolved

src/ng-select/ng-select.component.ts Outdated Show resolved Hide resolved

varnastadeus reviewed Oct 17, 2018

View reviewed changes

src/ng-select/ng-select.types.ts Show resolved Hide resolved

varnastadeus self-assigned this Oct 17, 2018

varnastadeus and others added 2 commits October 17, 2018 08:07

Use isDefined util

f6104c8

Set openOnEnter to true by default

f76f647

Switched to positive conditional for legibility

6bd2001

varnastadeus reviewed Oct 17, 2018

View reviewed changes

src/ng-select/ng-select.component.ts Outdated Show resolved Hide resolved

loose conditional for legibility

fd47b27

varnastadeus approved these changes Oct 17, 2018

View reviewed changes

varnastadeus merged commit fe9d990 into ng-select:master Oct 18, 2018

NickMele pushed a commit to NickMele/ng-select that referenced this pull request Apr 12, 2019

feat(openOnEnter): allow to configure whether enter opens dropdown

33f75d8

closes ng-select#878

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow form to submit when enter is pressed on a closed ng-select #878

Allow form to submit when enter is pressed on a closed ng-select #878

jakemdunn commented Oct 16, 2018

varnastadeus left a comment

coveralls commented Oct 17, 2018 •

edited

Allow form to submit when enter is pressed on a closed ng-select #878

Allow form to submit when enter is pressed on a closed ng-select #878

Conversation

jakemdunn commented Oct 16, 2018

varnastadeus left a comment

Choose a reason for hiding this comment

coveralls commented Oct 17, 2018 • edited

coveralls commented Oct 17, 2018 •

edited