Skip to content
This repository has been archived by the owner on Mar 10, 2023. It is now read-only.

bazelisk support #19

Closed
curtismuntz opened this issue Nov 28, 2019 · 4 comments
Closed

bazelisk support #19

curtismuntz opened this issue Nov 28, 2019 · 4 comments

Comments

@curtismuntz
Copy link

A lot of repositories are using bazelisk(an official bazelbuild project) to trivially change between bazel versions. It is instrumented off of a .bazelversion file in the workspace root. It'd be useful to have an action that keys off of this existing tool.

This would allow something like the following to support literally any previous/upcoming release of bazel, along with all of the amazing features provided by bazelisk:

uses: ngalaiko/bazel-action/bazelisk_1.1.0@master

I can make a PR that implements it very trivially, but figured I'd ask your thoughts on supporting this here. If this goes beyond the scope of this project, I can make a spin-off action called bazelisk-action as well.

Thanks!

@ngalaiko
Copy link
Owner

ngalaiko commented Nov 29, 2019

Hi!

Isn't bazelisk made to work with multiple workspaces that use different bazel versions locally?

For a given workspace you always know the version of bazel, so you can always use it in the actions file.

Why would you use bazelisk in CI?

@zegl
Copy link

zegl commented Nov 29, 2019

Why would you use bazelisk in CI?

bazelisk has some cool features such as --strict and --migrate which can be useful to use on CI to make sure that your Bazel setup is up-to-date.

@ngalaiko
Copy link
Owner

ngalaiko commented Dec 6, 2019

bazelisk has some cool features such as --strict and --migrate which can be useful to use on CI to make sure that your Bazel setup is up-to-date.

I am not sure that's the same use case as building / testing code with a known bazel version.

@curtismuntz what's your use-case for bazelisk in ci?

@ngalaiko
Copy link
Owner

ngalaiko commented Dec 19, 2019

Thank you for your input! I thought a bit about this, and I no longer see any reason for this action, see #25

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants