Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some initial review #5

Open
thanhtr opened this issue Jan 9, 2023 · 0 comments
Open

Some initial review #5

thanhtr opened this issue Jan 9, 2023 · 0 comments

Comments

@thanhtr
Copy link

thanhtr commented Jan 9, 2023

Issues

  • swagger yaml line 711 lacks items definition
  • config/stripe file missing (?)
  • yarn dev doesn't work atm without running build first. Consider adding nodemon config and use "start": "npx nodemon" instead for dev script

Suggestion

Improvement

  • dotenv is not setup (?). At least a .env for local development would be good
  • Bookings of charger can be a separate entity/document, rather than belongs to User
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant