Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote PHP7 to master #75

Closed
richarvey opened this issue Sep 19, 2016 · 5 comments
Closed

Promote PHP7 to master #75

richarvey opened this issue Sep 19, 2016 · 5 comments
Assignees
@richarvey
Milestone
Make PHP7 Default

Comments

@richarvey
Copy link
Owner

As PHP5 becomes (all be it) soft end of life in December we need to start staging the master branch to become the master branch.
@richarvey richarvey added this to the Make PHP7 Default milestone Sep 19, 2016
@richarvey
Copy link
Owner Author

created php5 branch in git and made docker hub build tag from that

@richarvey
Copy link
Owner Author

Need to Add PHP7 is now default to readme and promote when change happens

@ErikFontanel
Copy link

I noticed that the PHP7 branch pulls Alpine 3.4, hard coded. Not edge or latest tags, like master), Why is that? I had some trouble today because I learned that Alpine 3.4 comes with Nginx 1.10.2 instead of 1.11.x.

@richarvey
Copy link
Owner Author

It should be pulling edge hard coded. Its the only way to satisfy install deps without breaking.

@richarvey
Copy link
Owner Author

Switched master to PHP7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@richarvey richarvey

Labels
None yet
Projects
None yet
Milestone
Make PHP7 Default
Development

No branches or pull requests
3 participants
@richarvey @ErikFontanel @blerko