Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate CI to GitHub Actions as Travis CI is ending their free OSS builds #738

Merged
merged 10 commits into from Dec 23, 2020

Conversation

buchdag
Copy link
Member

@buchdag buchdag commented Dec 22, 2020

Following Travis CI's recent OSS announcement, the decision has been made to move the CI to GitHub Actions. This PR takes care of that. Thanks to @kmarilleau for contributing most of the new code and changes.

Background : Travis CI announced on November 2, 2020 that they were changing their pricing model.

The consequences for opens source projects are:

  • no more free unlimited build time, replaced by
  • 1000 minutes of build time allotted once (as in not renewed monthly) to each user account and org.

For reference, one full run (two jobs, one for two containers setup, the other for three containers setup) of this project's tests currently consume about 25 minutes of run time on Travis CI. We're already down to 263 minutes since the pricing model change took effect.

Travis CI claim that "an allotment of OSS minutes will be reviewed and allocated on a case by case basis" upon application. Such an application was made about one month ago. I haven't received any answer to date.

GitHub Actions seems to works pretty well and faster than Travis CI did without any run time limitation (yet).

The only, somewhat substantial "but" is that jwilder/docker-gen does not work properly on GitHub Actions runners. I've forked the upstream repository and made a patched branch that is being used to build patched nginx-proxy/nginx-proxy and jwilder/docker-gen containers that work on GitHub Actions. Appart from the patched docker-gen, they're identical to their upstream counterpart.

I still have to check local testing on Linux and MacOS, and will merge this once it's done next week.

@buchdag buchdag added the type/ci PR that change the CI configuration files and scripts label Dec 22, 2020
@buchdag
Copy link
Member Author

buchdag commented Dec 22, 2020

Credits where its due: I borrowed the PR title from dask/community#107

@buchdag
Copy link
Member Author

buchdag commented Dec 23, 2020

Merging, local tests on macOS aren't that high of a priority.

@buchdag buchdag merged commit 5e40af0 into nginx-proxy:master Dec 23, 2020
@buchdag buchdag deleted the github-actions branch December 23, 2020 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/ci PR that change the CI configuration files and scripts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants